Adds HTTP Get rate limitation on cache

We don't want to have a large bandwidth on bedetheque.com, so the pace
at which we perform GET request is limited by a maximal number of
request over a window (per example no more than 10 request over 10
second)

If more request are required, the request is simply paused until we go
back within the limit ;). Go rulez !
This commit is contained in:
2016-01-17 19:05:30 +01:00
parent b58b7e7e6a
commit c070c63463
3 changed files with 67 additions and 13 deletions

View File

@@ -4,7 +4,6 @@ import (
"encoding/json"
"fmt"
"io"
"net/http"
"os"
"path"
"path/filepath"
@@ -21,17 +20,17 @@ import (
type AlbumDescriptionCache struct {
basepath string
lock lockfile.Lockfile
getter HTTPGetter
// time to live of the cache, data which is older than this TTL will be automatically removed
TTL time.Duration
}
// NewAlbumDescriptionCache is creating a new album description at specified location
func NewAlbumDescriptionCache(path string) (*AlbumDescriptionCache, error) {
func NewAlbumDescriptionCache(path string, maxRequest uint, window time.Duration) (*AlbumDescriptionCache, error) {
res := &AlbumDescriptionCache{
basepath: path,
TTL: 3 * 31 * 24 * time.Hour, // 3 Months
getter: NewRateLimitedGetter(maxRequest, window),
TTL: 3 * 31 * 24 * time.Hour, // 3 Months
}
var err error
res.lock, err = lockfile.New(filepath.Join(path, "global.lock"))
@@ -79,7 +78,7 @@ func linkFromSelection(s *goquery.Selection) Link {
func (c *AlbumDescriptionCache) fetchAndCache(ID AlbumID) (*AlbumDescription, error) {
URL := path.Join("www.bedetheque.com", fmt.Sprintf("BD--%d.html", ID))
resp, err := http.Get("http://" + URL)
resp, err := c.getter.Get("http://" + URL)
if err != nil {
return nil, err
}
@@ -107,7 +106,7 @@ func (c *AlbumDescriptionCache) fetchAndCache(ID AlbumID) (*AlbumDescription, er
return
}
resp, err := http.Get(src)
resp, err := c.getter.Get(src)
if err != nil {
errors <- err
return
@@ -224,13 +223,20 @@ func (c *AlbumDescriptionCache) fetchAndCache(ID AlbumID) (*AlbumDescription, er
}
}
if len(errorList) == 0 {
return res, nil
if len(errorList) != 0 {
return nil, fmt.Errorf("Could not parse description from http://%s:%s",
URL,
strings.Join(append([]string{""}, errorList...), "\n * "))
}
return nil, fmt.Errorf("Could not parse description from http://%s:%s",
URL,
strings.Join(append([]string{""}, errorList...), "\n * "))
f, err := os.Create(c.albumPath(ID))
if err != nil {
return res, err
}
defer f.Close()
enc := json.NewEncoder(f)
return res, enc.Encode(res)
}
// GetDescription retrieves from the cache or either from www.bedetheque.com the AlbumDescription of an album